Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract modules from cardano-node to create package cardano-cli #819

Merged
merged 2 commits into from Apr 20, 2020
Merged

Extract modules from cardano-node to create package cardano-cli #819

merged 2 commits into from Apr 20, 2020

Conversation

intricate
Copy link
Contributor

No description provided.

@intricate intricate self-assigned this Apr 17, 2020
@intricate intricate force-pushed the intricate/cardano-cli-package branch 3 times, most recently from a1a2817 to d3ad04c Compare April 20, 2020 05:17
Jimbo4350
Jimbo4350 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small change and fix CI.

cardano-cli/NOTICE Outdated Show resolved Hide resolved
@intricate intricate force-pushed the intricate/cardano-cli-package branch 2 times, most recently from 13ab898 to f4737a6 Compare April 20, 2020 17:40
@intricate intricate mentioned this pull request Apr 20, 2020
Merged
dcoutts
dcoutts approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@intricate
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 20, 2020
@iohk-bors @intricate
Merge #819
c114b45 
819: Extract modules from cardano-node to create package cardano-cli r=intricate a=intricate



Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
@intricate
Copy link
Contributor Author

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 20, 2020

Canceled

@intricate intricate force-pushed the intricate/cardano-cli-package branch from f4737a6 to f5cf6f9 Compare April 20, 2020 20:46
@intricate
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 20, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 0bea62b into master Apr 20, 2020
@iohk-bors iohk-bors bot deleted the intricate/cardano-cli-package branch April 20, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@erikd erikd Awaiting requested review from erikd

Assignees

@intricate intricate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@intricate @erikd @dcoutts @Jimbo4350