Protocol plumbing in the node top level for starting in Shelley mode #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works, but cannot yet create blocks. Need to complete the support for reading the leader credentials.
It was hard coded, but we do actually have the protocol available, we just need to use it.
dcoutts
force-pushed
the
dcoutts/protocol-plumbing-shelley
branch
from
6383299
to
68d41f1
Compare
erikd
reviewed
Apr 19, 2020
| {-# LANGUAGE GeneralizedNewtypeDeriving #-} | ||
|
|
||
| {-# OPTIONS_GHC -fno-warn-orphans #-} | ||
| {-# OPTIONS_GHC -Wno-all-missed-specialisations #-} |
There was a problem hiding this comment.
Since we dropped -Weverything for -Wall that should not be needed.
There was a problem hiding this comment.
Yes. I've not added or removed these in these recent Shelley plumbing PRs.
There's over 20 of these remaining in the repo, in both cardano-config and cardano-node. I suggest we remove them all as part of a clean-up PR.
erikd
approved these changes
Apr 19, 2020
|
bors merge |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the tracing and protocol modules for the Shelly instance of the consensus+ledger.
Add
TPraos(transitional Praos) to the enumeration of protocols the node can use.No support yet for the leader credentials, so the node cannot yet create blocks.