Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more text view utils #829

Merged
merged 1 commit into from
Apr 22, 2020
Merged

more text view utils #829

merged 1 commit into from
Apr 22, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Apr 21, 2020

This adds more to Erik's TextView format utils.

It now covers:

  • parsing/rendering TextView format (as before)
  • checking the expected file type
  • CBOR encoding/decoding
  • reading/writing from files
  • all of the above included in structured errors
  • haddock docs

cardano-config/src/Cardano/Config/Shelley/OpCert.hs Outdated Show resolved Hide resolved
@@ -1,11 +1,26 @@
{-# LANGUAGE RankNTypes #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be placed after the OverloadedStrings LANGUAGE pragma.

And add more docs.

It now covers:
 * parsing/rendering TextView format (as before)
 * checking the expected file type
 * CBOR encoding/decoding
 * reading/writing from files
 * all of the above included in structured errors
@erikd
Copy link
Contributor

erikd commented Apr 22, 2020

bors r+

@IntersectMBO IntersectMBO deleted a comment from iohk-bors bot Apr 22, 2020
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcoutts dcoutts changed the title Shelley op certs and more text view utils more text view utils Apr 22, 2020
@dcoutts
Copy link
Contributor Author

dcoutts commented Apr 22, 2020

I've cut this down to just the text view utils. The opcert things (including tests) can follow on top of #816.

@dcoutts
Copy link
Contributor Author

dcoutts commented Apr 22, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 22, 2020

@iohk-bors iohk-bors bot merged commit 65d592d into master Apr 22, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/shelley-op-certs branch April 22, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants