Plumbing for loading Shelley node leader credentials #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
changed the title
Jimbo4350
reviewed
Apr 23, 2020
|
|
||
|
|
||
| ------------------------------------------------------------------------------ | ||
| -- Errors | ||
| -- | ||
|
|
||
| data ShelleyProtocolInstantiationError = | ||
| GenesisReadError !FilePath !String | ||
| GenesisReadError !FilePath !String |
| , configFp :: !ConfigYamlFilePath | ||
| , validateDB :: !Bool | ||
| , shutdownIPC :: !(Maybe Fd) | ||
| { nodeMode :: !NodeProtocolMode |
There was a problem hiding this comment.
Yep, way better than my initial attempt.
dcoutts
force-pushed
the
dcoutts/shelley-plumbing-leader-creds
branch
from
3be9a9e
to
c817df2
Compare
erikd
approved these changes
Apr 23, 2020
The NodeProtocolMode was splitting the configuration between the mock and real cases right at the very top level, eliminating any possibility of sharing between the cases. But in fact almost everything can be shared as there are currently few differences between the two cases. This adjusts the types so that most things are shared. This will make adding more things (for Shelley) rather easier.
KES, VRK and op cert files. Just CLI flags, not yet used.
For the OpCert we actually need the pair of the op cert and the corresponding verification key. Also, we need the op cert to use valid CBOR for its external rep, so we have to be a little careful with the to/fromCBORGroup stuff. Clarify this with explicit encoders and decoders. In all three modules, use local type aliases to simplify the type signatures. Also derive Show for the Error types, since we need to embed these inside bigger error types that themselves derive Show.
Use the VRF, KES and OpCert utils to load them all during the node startup, if they are specified on the command line. This is needed for the node to be able to make blocks.
dcoutts
force-pushed
the
dcoutts/shelley-plumbing-leader-creds
branch
from
c817df2
to
bcb1589
Compare
|
bors merge |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final patch is the one we're after, it does the final bit where we load up all the various files to make the Praos slot leader credentials.
First two patches are more refactoring. Then CLI plumbing. Finally some tweaks to the OpCert read/write code and then putting it all together by using it in the node startup code.