Stake address and stake pool delegation certificates #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
changed the title
intricate
reviewed
May 6, 2020
intricate
reviewed
May 6, 2020
cardano-api/src/Cardano/Api.hs
Outdated
| -- ^ Pool owners. | ||
| -> Seq.StrictSeq Shelley.StakePoolRelay | ||
| -- ^ Pool relays. | ||
| -> Shelley.StrictMaybe Shelley.PoolMetaData |
There was a problem hiding this comment.
Suggested change
| -> Shelley.StrictMaybe Shelley.PoolMetaData | |
| -> Shelley.StrictMaybe Shelley.PoolMetaData | |
| -- ^ Pool metadata. |
'cause why not 🤷♂️
intricate
reviewed
May 6, 2020
intricate
reviewed
May 6, 2020
dcoutts
requested changes
May 6, 2020
intricate
reviewed
May 6, 2020
intricate
reviewed
May 6, 2020
Comment on lines
163
to
+164
| deriving newtype Show | ||
| deriving Eq |
There was a problem hiding this comment.
Should be able to do:
Suggested change
| deriving newtype Show | |
| deriving Eq | |
| deriving newtype (Eq, Show) |
That is, unless there's some reason for not doing that, that I'm not aware of.
Jimbo4350
added
the
shelley testnet
Jimbo4350
force-pushed
the
jordan/delegation-and-stakepool-certs
branch
from
e5016bb
to
d65766d
Compare
dcoutts
previously requested changes
May 6, 2020
Comment on lines
+139
to
+150
| = ShelleyDelegationCertificate !ShelleyCertificate | ||
| | ShelleyStakePoolCertificate !ShelleyCertificate | ||
| deriving (Eq, Show) |
There was a problem hiding this comment.
If these are the same type, do we need two constructors?
There was a problem hiding this comment.
I use them in the CBOR: 68ef28c#diff-14c30ebd1606eb8a1efa6f0e506e71a8R79
Jimbo4350
force-pushed
the
jordan/delegation-and-stakepool-certs
branch
from
d65766d
to
73b5ea3
Compare
Jimbo4350
changed the title
2 tasks
Jimbo4350
force-pushed
the
jordan/delegation-and-stakepool-certs
branch
4 times, most recently
from
1799505
to
b2ee7f7
Compare
Create certificates to delegate your stake
Jimbo4350
force-pushed
the
jordan/delegation-and-stakepool-certs
branch
from
b2ee7f7
to
196b756
Compare
erikd
reviewed
May 9, 2020
| <*> genRewardAccountShelley | ||
| <*> genStakePoolOwnersShelley | ||
| <*> Gen.list (Range.linear 1 5) genStakePoolRelayShelley | ||
| <*> (Just <$> genPoolMetaDataShelley) |
There was a problem hiding this comment.
If that genuinely is optional, you should use Gen.maybe which is Nothing about 30% of the time.
erikd
approved these changes
May 9, 2020
…ates Integrate delegation and stake pool certificates in `buildShelleyTransaction`
Jimbo4350
force-pushed
the
jordan/delegation-and-stakepool-certs
branch
from
196b756
to
9df4f1c
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
May 9, 2020
890: Stake address and stake pool delegation certificates r=Jimbo4350 a=Jimbo4350 Issue ----------- - This PR **results** in breaking changes to upstream dependencies. Checklist --------- - [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [x] I have added the appropriate labels to this PR. Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Timed out |
|
bors merge |
Build succeeded |
iohk-bors bot
added a commit
that referenced
this pull request
May 9, 2020
895: Genesis stake address and MIR certificates r=Jimbo4350 a=Jimbo4350 Issue ----------- - Depends on #890 - This PR **does not result** in breaking changes to upstream dependencies. Checklist --------- - [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [x] I have added the appropriate labels to this PR. Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Checklist
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.