Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep metrics out of the log files. #930

Merged
merged 1 commit into from May 10, 2020
Merged

Keep metrics out of the log files. #930

merged 1 commit into from May 10, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented May 10, 2020

I wish we could do this once and for all. They should never appear in
log files by default.

@dcoutts
Keep metrics out of the log files.
ba37474 
I wish we could do this once and for all. They should never appear in
log files by default.
@dcoutts dcoutts requested review from erikd and CodiePP May 10, 2020 22:33
@dcoutts
Copy link
Contributor Author

dcoutts commented May 10, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 10, 2020

👎 Rejected by too few approved reviews

@erikd
Copy link
Contributor

erikd commented May 10, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 10, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 06a093e into master May 10, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/keep-metrics-out-of-the-log-files branch May 10, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@CodiePP CodiePP Awaiting requested review from CodiePP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dcoutts @erikd