make core unit test pass

cardano-foundation · Jul 29, 2021 · 06de6d5 · 06de6d5
1 parent 2c73e2c
commit 06de6d5
Show file tree

Hide file tree

Showing 3 changed files with 83 additions and 0 deletions.
diff --git a/lib/core/test/data/Cardano/Wallet/Api/ApiBalanceTransactionPostData.json b/lib/core/test/data/Cardano/Wallet/Api/ApiBalanceTransactionPostData.json
diff --git a/lib/core/test/unit/Cardano/Wallet/Api/Malformed.hs b/lib/core/test/unit/Cardano/Wallet/Api/Malformed.hs
@@ -52,6 +52,7 @@ import Prelude
 import Cardano.Wallet.Api.Types
     ( ApiAddressData
     , ApiAddressInspectData
+    , ApiBalanceTransactionPostData
     , ApiBytesT (..)
     , ApiConstructTransactionData
     , ApiMaintenanceActionPostData
@@ -1270,6 +1271,38 @@ instance Malformed (BodyParam ApiSignTransactionPostData) where
               )
             ]
 
+instance Malformed (BodyParam ApiBalanceTransactionPostData) where
+    malformed = jsonValid ++ jsonInvalid
+     where
+         jsonInvalid = first BodyParam <$>
+            [ ("1020344", "Error in $: parsing Cardano.Wallet.Api.Types.ApiBalanceTransactionPostData(ApiBalanceTransactionPostData) failed, expected Object, but encountered Number")
+            , ("\"hello\"", "Error in $: parsing Cardano.Wallet.Api.Types.ApiBalanceTransactionPostData(ApiBalanceTransactionPostData) failed, expected Object, but encountered String")
+            , ("{\"transaction\": \"\", \"random\"}", msgJsonInvalid)
+            , ("{\"transaction\": \"lah\"}", "Error in $.transaction: Parse error. Expecting Base64-encoded format.")
+            , ("{\"transaction\": 1020344}", "Error in $.transaction: parsing 'Base64 ByteString failed, expected String, but encountered Number")
+            , ("{\"transaction\": { \"body\": 1020344 }}", "Error in $.transaction: parsing 'Base64 ByteString failed, expected String, but encountered Object")
+            ]
+         jsonValid = first (BodyParam . Aeson.encode) <$>
+            [
+              ( [aesonQQ|
+                { "transaction": #{validSealedTxHex}
+                }|]
+              , "Error in $.transaction: Parse error. Expecting Base64-encoded format."
+              )
+            , ( [aesonQQ|
+               { "transaction": "cafecafe",
+                  "extra": "hello"
+               }|]
+               , "Error in $: parsing Cardano.Wallet.Api.Types.ApiBalanceTransactionPostData(ApiBalanceTransactionPostData) failed, unknown fields: ['extra']"
+              )
+            , ( [aesonQQ|
+               { "transaction": #{validSealedTxBase64},
+                  "extra": "hello"
+               }|]
+               , "Error in $: parsing Cardano.Wallet.Api.Types.ApiBalanceTransactionPostData(ApiBalanceTransactionPostData) failed, unknown fields: ['extra']"
+              )
+            ]
+
 instance Malformed (BodyParam (PostTransactionOldData ('Testnet pm))) where
     malformed = jsonValid ++ jsonInvalid
      where

diff --git a/lib/core/test/unit/Cardano/Wallet/Api/TypesSpec.hs b/lib/core/test/unit/Cardano/Wallet/Api/TypesSpec.hs
@@ -62,6 +62,7 @@ import Cardano.Wallet.Api.Types
     , ApiAddressDataPayload (..)
     , ApiAddressInspect (..)
     , ApiAsset (..)
+    , ApiBalanceTransactionPostData (..)
     , ApiBase64
     , ApiBlockInfo (..)
     , ApiBlockReference (..)
@@ -493,6 +494,7 @@ spec = parallel $ do
             jsonRoundtripAndGolden $ Proxy @(ApiConstructTransaction ('Testnet 0))
             jsonRoundtripAndGolden $ Proxy @ApiMultiDelegationAction
             jsonRoundtripAndGolden $ Proxy @ApiSignTransactionPostData
+            jsonRoundtripAndGolden $ Proxy @ApiBalanceTransactionPostData
             jsonRoundtripAndGolden $ Proxy @ApiSignedTransaction
             jsonRoundtripAndGolden $ Proxy @(PostTransactionOldData ('Testnet 0))
             jsonRoundtripAndGolden $ Proxy @(PostTransactionFeeOldData ('Testnet 0))
@@ -1008,6 +1010,13 @@ spec = parallel $ do
                     }
             in
                 x' === x .&&. show x' === show x
+        it "ApiBalanceTransactionPostData" $ property $ \x ->
+            let
+                x' = ApiBalanceTransactionPostData
+                    { transaction = transaction (x :: ApiBalanceTransactionPostData)
+                    }
+            in
+                x' === x .&&. show x' === show x
         it "PostMintBurnAssetData" $ property $ \x ->
           let
             x' = PostMintBurnAssetData
@@ -1917,6 +1926,9 @@ instance Arbitrary a => Arbitrary (AddressAmount a) where
 instance Arbitrary ApiSignTransactionPostData where
     arbitrary = ApiSignTransactionPostData <$> arbitrary <*> arbitrary
 
+instance Arbitrary ApiBalanceTransactionPostData where
+    arbitrary = ApiBalanceTransactionPostData <$> arbitrary
+
 instance Arbitrary (PostTransactionOldData t) where
     arbitrary = PostTransactionOldData
         <$> arbitrary
@@ -2478,6 +2490,9 @@ instance ToSchema ApiTxMetadata where
 instance ToSchema ApiSignTransactionPostData where
     declareNamedSchema _ = declareSchemaForDefinition "ApiSignTransactionPostData"
 
+instance ToSchema ApiBalanceTransactionPostData where
+    declareNamedSchema _ = declareSchemaForDefinition "ApiBalanceTransactionPostData"
+
 instance ToSchema ApiSignedTransaction where
     -- fixme: tests don't seem to like allOf
     declareNamedSchema _ = declareSchemaForDefinition "ApiSignedTransaction"