Skip to content

Commit

Permalink
.gitattributes: Minimize golden test JSON files in GitHub PR
Browse files Browse the repository at this point in the history
This causes golden JSON files used for tests to be hidden by default
in the GitHub PR review page. They are hidden in the same way that
"large diffs" are hidden by default.

The reviewer can then concentrate on the substance of the PR, and then
inspect JSON files by clicking on the "Load diff" link.
  • Loading branch information
rvl committed Dec 17, 2020
1 parent c955ca6 commit 39720e9
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .gitattributes
Expand Up @@ -11,3 +11,9 @@ nix/sources.nix linguist-generated=true

# Hide the Cabal freeze file
cabal.project.freeze linguist-generated=true

# Hide golden JSON files used for tests
# - they clog up the GitHub PR review page.
# Also set the "binary" merge mode for Git,
# because textual merging of auto-generated JSON rarely works well.
lib/core/test/data/Cardano/Wallet/Api/*.json linguist-generated=true merge=binary

0 comments on commit 39720e9

Please sign in to comment.