Use runSelectionNonEmpty in performSelection.

This usage replaces `runSelection`, which may return an empty selection.
cardano-foundation · Sep 12, 2021 · 53a8221 · 53a8221
1 parent 2fcfb4a
commit 53a8221
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/lib/core/src/Cardano/Wallet/Primitive/CoinSelection/Balance.hs b/lib/core/src/Cardano/Wallet/Primitive/CoinSelection/Balance.hs
@@ -513,20 +513,21 @@ performSelection minCoinFor costFor bundleSizeAssessor criteria
             NE.fromList insufficientMinCoinValues
 
     | otherwise = do
-        state <- runSelection RunSelectionParams
+        maybeSelection <- runSelectionNonEmpty RunSelectionParams
             { selectionLimit
             , extraCoinSource
             , utxoAvailable
             , minimumBalance = balanceRequired
             }
-        let balanceSelected = fullBalance (selected state) extraCoinSource
-        if balanceRequired `leq` balanceSelected then
-            makeChangeRepeatedly state
-        else
-            pure $ Left $ SelectionInsufficient $ SelectionInsufficientError
-                { inputsSelected = UTxOIndex.toList (selected state)
-                , balanceRequired
-                }
+        case maybeSelection of
+            Nothing ->
+                selectionInsufficientError []
+            Just selection -> do
+                let utxoSelected = selected selection
+                let balanceSelected = fullBalance utxoSelected extraCoinSource
+                if balanceRequired `leq` balanceSelected
+                then makeChangeRepeatedly selection
+                else selectionInsufficientError $ UTxOIndex.toList utxoSelected
   where
     SelectionCriteria
         { outputsToCover
@@ -537,6 +538,13 @@ performSelection minCoinFor costFor bundleSizeAssessor criteria
         , assetsToBurn
         } = criteria
 
+    selectionInsufficientError :: [(TxIn, TxOut)] -> m (Either SelectionError a)
+    selectionInsufficientError inputsSelected =
+        pure $ Left $ SelectionInsufficient $ SelectionInsufficientError
+            { inputsSelected
+            , balanceRequired
+            }
+
     requestedOutputs = F.foldMap (view #tokens) outputsToCover
     requestedOutputAssets = view #tokens requestedOutputs