Skip to content

Commit

Permalink
docs: Merge #3785 3785: Wallet captures tx fee regardless of the tx m…
Browse files Browse the repository at this point in the history
…eta direction r=Unisay a=Unisay ### Context 1. I create a "Quit Stake Pool" transaction and submit it to the network'. 1. Once its incorporated in the ledger its received back by the same wallet. ### Expected behavior The transaction is shown in the history and I can see how much in fees it costed me as well as the refund (2 ADA atm) I am getting for de-registering my staking key. ### Actual behavior The transaction is shown in the history but its "Fee" field is zero. As if I didn't pay fee for it. The Tx is still valid from the ledger perspective as received refund is greater than fee and so its covering the costs. Investigation has shown that there is a piece of code that discards fees for all transactions having a meta-"direction" == "Incoming". This PR changes the previous behavior, such that fees will be always shown, regardless of which wallet created transaction, and which direction transaction funds go. ### Issue Number ADP-2840
 Co-authored-by: Yura Lazarev <Unisay@users.noreply.github.com> Source commit: 120c7de
  • Loading branch information
William King Noel Bot committed Mar 15, 2023
1 parent cfcc1bb commit 62a078c
Show file tree
Hide file tree
Showing 60 changed files with 60 additions and 60 deletions.
2 changes: 1 addition & 1 deletion -/all.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion -/tags.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion -/tasks.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion archives.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion archives/jormungandr.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion archives/jormungandr/Docker-jormungandr.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/address-derivation.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/byron-address-format.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/coin-selection.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/hierarchical-deterministic-wallets.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<script async id='MathJax-script' src='https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js'></script>


<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/master-key-generation.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<script src='https://cdnjs.cloudflare.com/ajax/libs/prism/1.26.0/plugins/autoloader/prism-autoloader.min.js'></script>


<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/recovery-phrases.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script async id='MathJax-script' src='https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js'></script>


<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/transaction-lifecycle.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</script>


<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/utxo.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Logging-Guidelines.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Nix.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Notes-from-upgrading-GHC-version.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Release-Process.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Swagger-Development.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Testing.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Updating-Dependencies.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/Eras.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/Notes-about-BIP-44.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/Specifying-exceptions-with-Servant-and-Swagger.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/WalletId.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<script async id='MathJax-script' src='https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js'></script>


<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/records.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/records/2021-01-17-nix-flake.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/specs.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/specs/light-mode.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</script>


<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers/Architecture.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</script>


<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers/Building.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers/Resources.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers/api-references.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion user-guide.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion user-guide/EKG-and-Prometheus-metrics.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion user-guide/Integrations.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion user-guide/cli.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion user-guide/common-use-cases.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=177f26a3-d284-4e27-8428-2e624070a2a1' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=dd8ba68c-6ffa-4772-99b4-8c511f9c619d' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down

0 comments on commit 62a078c

Please sign in to comment.