Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
2455: waitForTxImmutability in fixtureWalletWith r=Anviking a=Anviking # Issue Number <!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. --> Hopefully fixes all of #2426, #2430, #2439 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Add waitForTxImmutability in fixtureWalletWith # Comments ``` I hope this should fix the flaky TRANS_LIST failures. I tested locally with setup: - anviking/prototype/lsq-monad - patch adding replicateM_ on TRANS_LIST failuries - patch removing retrying `it` - running stack test cardano-wallet:integration --ta '-j 6' With resulting failures: without 5s threadDelay: - 1 (TRANS_LIST) failure - 1 (TRANS_LIST) failure with threadDelay: - 1 (other failure) - 0 failures on master, with waitForTxImmutability instead of threadDelay - 0 failures ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
- Loading branch information