Apply suggestions from code review

Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>
cardano-foundation · May 30, 2023 · 73091b9 · 73091b9
1 parent 64479aa
commit 73091b9
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 11 deletions.
diff --git a/lib/wallet/src/Cardano/Wallet.hs b/lib/wallet/src/Cardano/Wallet.hs
@@ -1879,19 +1879,17 @@ readNodeTipStateForTxWrite
     :: NetworkLayer IO Read.Block
     -> IO (Write.InAnyRecentEra Write.ProtocolParameters, TimeTranslation)
 readNodeTipStateForTxWrite netLayer = do
-    let ti = timeInterpreter netLayer
-    timeTranslation <- toTimeTranslation ti
+    timeTranslation <- toTimeTranslation (timeInterpreter netLayer)
 
     res <- currentLedgerProtocolParameters
         <$> currentProtocolParameters netLayer
 
     case Write.toRecentEraGADT res of
-        Right pp ->
-            pure (pp, timeTranslation)
+        Right pp -> pure (pp, timeTranslation)
         Left era -> throwIO $ invalidEra era
   where
-    invalidEra = ExceptionWriteTxEra
-        . ErrNodeNotYetInRecentEra
+    invalidEra =
+        ExceptionWriteTxEra . ErrNodeNotYetInRecentEra
 
 -- | Build, Sign, Submit transaction.
 --
@@ -2017,7 +2015,14 @@ buildAndSignTransactionPure
     wallet <- get
     (unsignedBalancedTx, updatedWalletState) <- lift $
         buildTransactionPure @s @era
-            wallet timeTranslation utxoIndex txLayer changeAddrGen pp preSelection txCtx
+            wallet
+            timeTranslation
+            utxoIndex
+            txLayer
+            changeAddrGen
+            pp
+            preSelection
+            txCtx
     put wallet { getState = updatedWalletState }
 
     let mExternalRewardAccount = case view #txWithdrawal txCtx of

diff --git a/lib/wallet/src/Cardano/Wallet/Shelley/Compatibility.hs b/lib/wallet/src/Cardano/Wallet/Shelley/Compatibility.hs
@@ -894,7 +894,6 @@ fromShelleyPParams eraInfo pp =
         , minimumCollateralPercentage = 0
         , executionUnitPrices = Nothing
         , currentLedgerProtocolParameters = Write.InNonRecentEraShelley
-
         }
 
 fromAllegraPParams

diff --git a/lib/wallet/src/Cardano/Wallet/Write/ProtocolParameters.hs b/lib/wallet/src/Cardano/Wallet/Write/ProtocolParameters.hs
@@ -25,6 +25,9 @@ newtype ProtocolParameters era = ProtocolParameters
         :: Write.PParams (Write.ShelleyLedgerEra era)
     }
 
-deriving instance Eq (Write.PParams (Write.ShelleyLedgerEra era)) => Eq (ProtocolParameters era)
-deriving instance Show (Write.PParams (Write.ShelleyLedgerEra era)) => Show (ProtocolParameters era)
-
+deriving instance
+    Eq (Write.PParams (Write.ShelleyLedgerEra era)) =>
+    Eq (ProtocolParameters era)
+deriving instance
+    Show (Write.PParams (Write.ShelleyLedgerEra era)) =>
+    Show (ProtocolParameters era)