update integration test

cardano-foundation · Oct 13, 2021 · 856a74e · 856a74e
1 parent 1ae5d26
commit 856a74e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/lib/core-integration/src/Test/Integration/Framework/TestData.hs b/lib/core-integration/src/Test/Integration/Framework/TestData.hs
@@ -98,6 +98,7 @@ module Test.Integration.Framework.TestData
     , errMsg403TemplateInvalidScript
     , errMsg403InvalidConstructTx
     , errMsg403transactionAlreadyBalanced
+    , errMsg403MissingWitnesses
     ) where
 
 import Prelude
@@ -626,6 +627,10 @@ errMsg403transactionAlreadyBalanced :: String
 errMsg403transactionAlreadyBalanced =
     "The transaction is already balanced. Please send a transaction that requires more inputs/outputs to be picked to be balanced."
 
+errMsg403MissingWitnesses :: String
+errMsg403MissingWitnesses =
+    "I couldn't submit a transaction with missing witnesses."
+
 --------------------------------------------------------------------------------
 -- Transaction metadata
 --------------------------------------------------------------------------------

diff --git a/lib/core-integration/src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs b/lib/core-integration/src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs
@@ -126,6 +126,7 @@ import Test.Integration.Framework.TestData
     ( errMsg403Fee
     , errMsg403InvalidConstructTx
     , errMsg403MinUTxOValue
+    , errMsg403MissingWitnesses
     , errMsg403NotDelegating
     , errMsg403NotEnoughMoney
     , errMsg403transactionAlreadyBalanced
@@ -1130,7 +1131,9 @@ spec = describe "NEW_SHELLEY_TRANSACTIONS" $ do
             request @(ApiConstructTransaction n) ctx constructEndpoint Default payload
 
         -- Submit tx
-        void $ submitTx ctx sealedTx [ expectResponseCode HTTP.status500 ]
+        void $ submitTx ctx sealedTx
+            [ expectResponseCode HTTP.status403
+            , expectErrorMessage errMsg403MissingWitnesses ]
 
     it "TRANS_NEW_SIGN_03 - Sign withdrawals" $ \ctx -> runResourceT $ do
         (w, _) <- rewardWallet ctx

diff --git a/lib/core/src/Cardano/Wallet/Api/Server.hs b/lib/core/src/Cardano/Wallet/Api/Server.hs
@@ -3822,7 +3822,7 @@ instance IsServerError ErrSubmitTx where
             }
         ErrSubmitTxImpossible e -> toServerError e
         ErrSubmitTxMissingWitnesses ->
-            apiError err404 MissingWitnesses $ mconcat
+            apiError err403 MissingWitnesses $ mconcat
                 [ "I couldn't submit a transaction with missing witnesses."
                 ]
 

diff --git a/lib/core/src/Cardano/Wallet/Primitive/Types/Tx.hs b/lib/core/src/Cardano/Wallet/Primitive/Types/Tx.hs
@@ -1,5 +1,4 @@
 {-# LANGUAGE DataKinds #-}
-{-# LANGUAGE DeriveAnyClass #-}
 {-# LANGUAGE DeriveFunctor #-}
 {-# LANGUAGE DeriveGeneric #-}
 {-# LANGUAGE DerivingVia #-}