Skip to content

Commit

Permalink
Merge #3081
Browse files Browse the repository at this point in the history
3081: Increase timeouts for fetching node in benchmarks and e2e tests r=rvl a=piotr-iohk

- [x] I have increased timeouts in restoration benchmarks and e2e tests

### Comments

Follow up to #3079.
 - e2e tests 120 mins was not enough for [MacOS](https://github.com/input-output-hk/cardano-wallet/actions/runs/1689464914). 
   - 🧪 [Testing](https://github.com/input-output-hk/cardano-wallet/actions/runs/1691714591). 180mins ✔️ 
 - hopefully the same issue in [benchmarks](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1216#68ecaf3e-2649-4d9e-804e-bef3bad97fc). 
   - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1218)  180mins ❌ 
   - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1219) 240mins ✔️ (build failed due to cancellation signal 🤔 , but passed through connecting to the node)

### Issue Number

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
  • Loading branch information
iohk-bors[bot] and Piotr Stachyra committed Jan 18, 2022
2 parents c02b6c2 + 29a9b30 commit a5085ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/shelley/bench/restore-bench.hs
Expand Up @@ -778,7 +778,7 @@ waitForNodeSync
=> Tracer IO (BenchmarkLog n)
-> NetworkLayer IO Block
-> IO SlotNo
waitForNodeSync tr nw = loop 480 -- allow 120 minutes for first tip
waitForNodeSync tr nw = loop 960 -- allow 240 minutes for first tip
where
loop :: Int -> IO SlotNo
loop retries = do
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/Rakefile
Expand Up @@ -86,8 +86,8 @@ task :wait_until_node_synced do
puts "\n >> Waiting for node to be synced"

network = CardanoWallet.new.misc.network
# it seems that occasionally cardano-node needs more time to spin up
timeout = 7200
# allow 180 mins for connecting to the node in case it needs to replay ledger
timeout = 10800
current_time = Time.now
timeout_treshold = current_time + timeout
puts "Timeout: #{timeout}s"
Expand Down

0 comments on commit a5085ac

Please sign in to comment.