expect fee in incoming txs in e2e tests

cardano-foundation · Mar 17, 2023 · c226379 · c226379
1 parent 7d4f880
commit c226379
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 23 deletions.
diff --git a/test/e2e/spec/e2e_shared_spec.rb b/test/e2e/spec/e2e_shared_spec.rb
@@ -196,7 +196,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(target_wid, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -308,7 +308,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(target_wid, tx_id)
         tx_amount(txt, amt * 2)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -421,7 +421,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(target_wid, tx_id)
         tx_amount(txt, amt_ada)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -534,7 +534,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(target_wid, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -676,7 +676,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(target_wid, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -779,7 +779,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -876,7 +876,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt * 2)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -980,7 +980,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt_ada)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -1080,7 +1080,7 @@
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        tx_fee(tx, expected_fee)
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -1396,7 +1396,7 @@
 
         # on target wallet
         txt = SHARED.transactions.get(@wid_sha, tx_id)
-        tx_fee(txt, 0)
+        expect(tx['fee']['quantity'].to_i).to be > 0
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')

diff --git a/test/e2e/spec/e2e_spec.rb b/test/e2e/spec/e2e_spec.rb
@@ -825,7 +825,7 @@ def script_hash
       # on target wallet
       txt = SHELLEY.transactions.get(@target_id, tx_id)
       tx_amount(txt, amt)
-      tx_fee(txt, 0)
+      tx_fee(tx, expected_fee)
       tx_inputs(txt, present: true)
       tx_outputs(txt, present: true)
       tx_direction(txt, 'incoming')
@@ -924,7 +924,7 @@ def script_hash
       # on target wallet
       txt = SHELLEY.transactions.get(@target_id, tx_id)
       tx_amount(txt, amt * 2)
-      tx_fee(txt, 0)
+      tx_fee(tx, expected_fee)
       tx_inputs(txt, present: true)
       tx_outputs(txt, present: true)
       tx_direction(txt, 'incoming')
@@ -1027,7 +1027,7 @@ def script_hash
       # on target wallet
       txt = SHELLEY.transactions.get(@target_id, tx_id)
       tx_amount(txt, amt_ada)
-      tx_fee(txt, 0)
+      tx_fee(tx, expected_fee)
       tx_inputs(txt, present: true)
       tx_outputs(txt, present: true)
       tx_direction(txt, 'incoming')
@@ -1287,7 +1287,7 @@ def script_hash
       # on target wallet
       txt = SHELLEY.transactions.get(@target_id, tx_id)
       tx_amount(txt, amt)
-      tx_fee(txt, 0)
+      tx_fee(tx, expected_fee)
       tx_inputs(txt, present: true)
       tx_outputs(txt, present: true)
       tx_direction(txt, 'incoming')
@@ -1449,7 +1449,7 @@ def script_hash
       tx = SHELLEY.transactions.get(@target_id, tx_id)
       expect(tx['amount']['quantity']).to be > 0
       expect(tx['amount']['quantity']).to be < deposit_returned
-      tx_fee(tx, 0)
+      tx_fee(tx, expected_fee)
       tx_inputs(tx, present: true)
       tx_outputs(tx, present: true)
       tx_direction(tx, 'incoming')
@@ -2572,7 +2572,8 @@ def script_hash
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        # in old tx workflow, only expecting fee to be present because fee calculation is not reliable enough for strong assertions
+        expect(tx['fee']['quantity'].to_i).to be > 0
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -2639,7 +2640,7 @@ def script_hash
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        expect(tx['fee']['quantity'].to_i).to be > 0
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -2730,7 +2731,7 @@ def script_hash
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        expect(tx['fee']['quantity'].to_i).to be > 0
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -2797,7 +2798,7 @@ def script_hash
         # on target wallet
         txt = SHELLEY.transactions.get(@target_id, tx_id)
         tx_amount(txt, amt)
-        tx_fee(txt, 0)
+        expect(tx['fee']['quantity'].to_i).to be > 0
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')
@@ -3014,7 +3015,7 @@ def script_hash
         tx = SHELLEY.transactions.get(@target_id, quit_tx_id)
         expect(tx['amount']['quantity']).to be > 0
         expect(tx['amount']['quantity']).to be < deposit
-        tx_fee(tx, 0)
+        expect(tx['fee']['quantity'].to_i).to be > 0
         tx_inputs(tx, present: true)
         tx_outputs(tx, present: true)
         tx_direction(tx, 'incoming')
@@ -3174,7 +3175,7 @@ def test_byron_tx(source_wid, target_wid)
       # on target wallet
       txt = SHELLEY.transactions.get(target_wid, tx_id)
       tx_amount(txt, amt)
-      tx_fee(txt, 0)
+      tx_fee(tx, fee)
       tx_inputs(txt, present: true)
       tx_outputs(txt, present: true)
       tx_direction(txt, 'incoming')
@@ -3263,7 +3264,7 @@ def test_byron_assets_tx(source_id, target_id)
       # on target wallet
       txt = SHELLEY.transactions.get(target_id, tx_id)
       tx_amount(txt, amt_ada)
-      tx_fee(txt, 0)
+      tx_fee(tx, fee)
       tx_inputs(txt, present: true)
       tx_outputs(txt, present: true)
       tx_direction(txt, 'incoming')
@@ -3529,7 +3530,7 @@ def test_byron_trans_list(wid)
 
         # on target wallet
         txt = SHELLEY.transactions.get(@wid, tx_id)
-        tx_fee(txt, 0)
+        expect(tx['fee']['quantity'].to_i).to be > 0
         tx_inputs(txt, present: true)
         tx_outputs(txt, present: true)
         tx_direction(txt, 'incoming')