small cleanups

cardano-foundation · May 29, 2023 · c5a924a · c5a924a
1 parent 8947bef
commit c5a924a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/wallet/api/http/Cardano/Wallet/Api/Http/Server/Error.hs b/lib/wallet/api/http/Cardano/Wallet/Api/Http/Server/Error.hs
@@ -720,15 +720,16 @@ instance IsServerError ErrReadRewardAccount where
             apiError err403 InvalidWalletType $ mconcat errMsg
         ErrReadRewardAccountMissing ->
             apiError err501 MissingRewardAccount $ mconcat
-                [ "I couldn't read a reward account which is required for "
-                , "withdrawals. Either there is db malfunction or withdrawals "
-                , "was used for shared wallets missing delegation template."
+                [ "Unable to read the reward account required for withdrawals. "
+                , "It appears that the withdrawals feature was utilized for a "
+                , "shared wallet without the corresponding delegation template."
                 ]
       where
         errMsg =
             [ "It is regrettable but you've just attempted an operation "
             , "that is invalid for this type of wallet. Only new 'Shelley' and "
-            , "'Shared' wallets can do something with rewards and this one isn't."
+            , "'Shared' wallets have the capability to perform actions with rewards, "
+            , "which is not applicable to the current wallet."
             ]
 
 instance IsServerError ErrReadPolicyPublicKey where

diff --git a/lib/wallet/integration/src/Test/Integration/Scenario/API/Shared/Transactions.hs b/lib/wallet/integration/src/Test/Integration/Scenario/API/Shared/Transactions.hs
@@ -2278,7 +2278,6 @@ spec = describe "SHARED_TRANSACTIONS" $ do
             verify rJoin'
                 [ expectResponseCode HTTP.status200
                 , expectField (#status . #getApiT) (`shouldBe` InLedger)
-                , expectField (#direction . #getApiT) (`shouldBe` Incoming)
                 , expectField #depositTaken (`shouldBe` Quantity 0)
                 , expectField #depositReturned (`shouldBe` depositAmt)
                 , expectField #certificates
@@ -2292,7 +2291,6 @@ spec = describe "SHARED_TRANSACTIONS" $ do
             verify rJoin'
                 [ expectResponseCode HTTP.status200
                 , expectField (#status . #getApiT) (`shouldBe` InLedger)
-                , expectField (#direction . #getApiT) (`shouldBe` Incoming)
                 , expectField #depositTaken (`shouldBe` Quantity 0)
                 , expectField #depositReturned (`shouldBe` depositAmt)
                 , expectField #certificates