Add continuous integration to cardano-coin-selection library.

[jonathanknowles]

Context

As part of the work to create a separate coin selection and fee balancing library, we'll need a way to automatically test new code that is introduced.

Decision

Add continuous integration support to the cardano-coin-selection library.

Acceptance Criteria

• The cardano-coin-selection library must have CI support.
• The CI system must detect and report:
  • compilation failures
  • test failures
  • lint failures (hlint)
  • style failures (stylish-haskell)
• The CI system must run for every pull request.
• The CI system must run for every merge into master.
• The status of the latest master build should be visible on the home page.

Development

• Add continuous integration support based on the script used for the bech32 library.
• Add a badge to the home page showing the status of the latest build.

QA

Try to cause the CI system to fail, by pushing a branch with the following types of failure:

• Failure to compile:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657112216
• Failure of the lint check:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657110157
• Failure of the style check:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657114386
• Failure of the test suite:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657115878

[paweljakubas]

would be good to have it in such a form (eg., using repo name variables propagated throughout the code ) that it is very quick to reuse it in other repositories we are going to spawn

[jonathanknowles]

@paweljakubas wrote:

would be good to have it in such a form (eg., using repo name variables propagated throughout the code ) that it is very quick to reuse it in other repositories we are going to spawn

Good point!

The CI code is fortunately very simple, for the moment. It doesn't even mention the library name. See:

https://github.com/input-output-hk/cardano-coin-selection/blob/master/.travis.yml

[jonathanknowles]

Hi @piotr-iohk!

I've just run a few tests on the CI system, just to check that it does fail as expected. According to my tests, it correctly rejects the following kinds of failure:

• Failure to compile:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657112216
• Failure of the lint check:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657110157
• Failure of the style check:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657114386
• Failure of the test suite:
  https://travis-ci.org/input-output-hk/cardano-coin-selection/builds/657115878

Would you be okay with me closing this issue?

[piotr-iohk]

@jonathanknowles - OK for the CI :) One question though:

Add code coverage based on the script used for the bech32 library.

Is there a code coverage set up? can it the seen somewhere? (a badge for CC would be handy too)

[jonathanknowles]

@jonathanknowles - OK for the CI :) One question though:

Add code coverage based on the script used for the bech32 library.

Is there a code coverage set up? can it the seen somewhere? (a badge for CC would be handy too)

There's a separate issue for that here: https://github.com/input-output-hk/cardano-wallet/issues/1390

[piotr-iohk]

Ok, thx. The point Add code coverage based on the script used for the bech32 library. is part of the Developement section, hence my question. Closing then!

[jonathanknowles]

Ok, thx. The point Add code coverage based on the script used for the bech32 library. is part of the Developement section, hence my question. Closing then!

Ah, that was a typo! I've corrected it to read:

Add continuous integration support based on the script used for the bech32 library.