Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize module structure of cardano-coin-selection repository. #1380

Closed
7 tasks done
jonathanknowles opened this issue Feb 26, 2020 · 1 comment
Closed
7 tasks done
Assignees

Comments

@jonathanknowles
Copy link
Member

jonathanknowles commented Feb 26, 2020

Context

As part of the work to create a separate coin selection and fee balancing library, we created a repository based on minimal changes to the existing cardano-wallet library.

Decision

Simplify the module hierarchy in cardano-coin-selection, so that:

  • Functions and types that are only used by tests are moved into the test suite.
  • Functions and types that are located in "general-purpose" modules are moved into dedicated modules, related to their purpose.

Acceptance Criteria

  • There should be no functions or types defined within src that are used only for testing.

Development

Move the following modules:

  • Cardano.UnsafeTest.Unsafe.
  • Data.Vector.ShuffleTest.Vector.Shuffle.
  • Data.Vector.ShuffleSpecTest.Vector.ShuffleSpec.

QA

  • Verify that there are no functions or types defined within src that are used only for testing.
@jonathanknowles jonathanknowles changed the title Consolidate module structure of cardano-coin-selection library. Consolidate cardano-coin-selection library module structure. Feb 26, 2020
@jonathanknowles jonathanknowles changed the title Consolidate cardano-coin-selection library module structure. Consolidate module structure of cardano-coin-selection library. Feb 26, 2020
@jonathanknowles jonathanknowles changed the title Consolidate module structure of cardano-coin-selection library. Reorganize module structure of cardano-coin-selection library. Feb 26, 2020
@jonathanknowles jonathanknowles self-assigned this Feb 27, 2020
@jonathanknowles jonathanknowles changed the title Reorganize module structure of cardano-coin-selection library. Reorganize module structure of cardano-coin-selection repository. Mar 13, 2020
@piotr-iohk
Copy link
Contributor

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants