You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wallet metadata are now correctly created in the wallet layer when creating a wallet
UUID has been replaced with an hex-encoded hash of the root public key for the wallet id (this is reflected in the golden tests) and visible through the type of WalletId as well (cf haddock
I've extended properties for the wallet layer as well to check that the wallet id generation is both deterministic and injective (cf: Cardano.WalletSpec)
Wallet Metadata are also now stored in the DB Layer (DB layer has been extended to cover for those cases, see hereputWalletMeta and readWalletMeta)
Also added extra tests for the wallet metadata and actually, tx history too in Cardano.Wallet.DB.MVarSpec
The text was updated successfully, but these errors were encountered:
Context
Before we create a proper SQL DB Store, we'd like to finalize the wallet metadata.
In the our current
MVar
DB layer we're not storingWalletMetadata
. We'd like to do that.The current
WalletId
is anUUID
.We want the wallet id to be deterministic. We do not want to use (and expose) the root public key directly for security reasons…
Decision
…instead, compute the wallet id using a base16/hex-encoded hash (e.g. Blake2b 128) of root xpub. And — store
WalletMetadata
in the DB.Acceptance Criteria
WalletMetadata
must be stored in theDBLayer
WalletId
should be redefined as a hex-encodedBlake2b 128
-hash of the root public key.Development Plan
PR
master
master
QA
WalletId
as well (cf haddockputWalletMeta
andreadWalletMeta
)The text was updated successfully, but these errors were encountered: