Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more asset tests #2488

Merged
merged 2 commits into from Feb 4, 2021
Merged

more asset tests #2488

merged 2 commits into from Feb 4, 2021

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Feb 3, 2021 •
edited by rvl

Issue Number

ADP-604

Overview

  • More asset tests for shelley wallets.

Comments

馃毀

@piotr-iohk piotr-iohk self-assigned this Feb 3, 2021
rvl
rvl approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@rvl rvl force-pushed the piotr/more-assets-integration-tests branch 2 times, most recently from d2ec1ae to a85d7b2 Compare February 4, 2021 10:20
@rvl
tests: Fix Link.getAsset type
df54526 
It was a bit messed up, oops.
@rvl rvl force-pushed the piotr/more-assets-integration-tests branch from a85d7b2 to df54526 Compare February 4, 2021 10:21
@rvl
Copy link
Contributor

rvl commented Feb 4, 2021

I fixed up Link.getAsset so that it's usable, and marked some tests pending until the API handlers are fixed.

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 4, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit a5a77b8 into master Feb 4, 2021
@iohk-bors iohk-bors bot deleted the piotr/more-assets-integration-tests branch February 4, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piotr-iohk @rvl