Enable transaction support in integration tests for cardano-http-bridge #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
force-pushed
the
KtorZ/220/transactions-in-integration-tests
branch
from
6509b05
to
124f026
Compare
piotr-iohk
reviewed
May 14, 2019
|
|
||
| -- | A faucet / genesis UTxO generate from the configuration.yaml. | ||
| -- The secret key can be generated using `cardano-keygen`, and then, using | ||
| -- `deriveForstHDAddress` from cardano-sl to get the corresponding address key. |
piotr-iohk
reviewed
May 14, 2019
| -- | Get the first address for that wallet | ||
| let (Right seed) = fromMnemonic @'[15] mnemonics | ||
| let (Right pwd) = fromText "cardano-wallet" | ||
| let addr0 = firstAddress (seed, pwd) |
There was a problem hiding this comment.
I suppose It would be actually quite useful to implement the listAddress endpoint and use it for this...
There was a problem hiding this comment.
Hmmm.. Yes, and no. The wallets above aren't in the API yet. That's the whole point, we simply create a transaction to the corresponding addresses, and, if restored, the wallets will already have some funds :)
There was a problem hiding this comment.
(would be clearer with the next incoming PR, but generally speaking, I do agree about implementing the listAddress endpoint. I think I'll tackle that as part of the debt).
|
Looks good (but does not compile ;) ) |
KtorZ
force-pushed
the
KtorZ/220/transactions-in-integration-tests
branch
from
124f026
to
95d08dd
Compare
Yes, just noticed some functionalities moved from a module to another :) .. Fixed. |
…ding some context about the request
KtorZ
force-pushed
the
KtorZ/220/transactions-in-integration-tests
branch
2 times, most recently
from
3ae6341
to
e9f85a0
Compare
… test to show it works
…tility to generate wallet with funds
Moved all function implementations under a 'where' clause for better readability. This also allows for doing some extra bootstraping prior to creating the wallet layer
KtorZ
force-pushed
the
KtorZ/220/transactions-in-integration-tests
branch
from
e9f85a0
to
55154e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#220
Overview
Comments
To be done: initialize a hundred wallets with funds by making an initial "setup" transaction to addresses we control (with known mnemonics). Later, these wallets can be restored and used in integration scenarios.