Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark MVar DB properties pending on macOS #2714

Merged
merged 1 commit into from Jun 16, 2021
Merged

Mark MVar DB properties pending on macOS #2714

merged 1 commit into from Jun 16, 2021

Conversation

Anviking
Copy link
Collaborator

@Anviking Anviking commented Jun 15, 2021 •
edited

Issue Number

#2472 / ADP-970

Overview

  • Make MVar DB properties pending on macOS (see commit message)

Comments

@Anviking
Mark MVar DB properties pending on macOS
96b6cc7 
Unit tests on macOS hydra builds are regularly timing out.

Rough analysis suggests more than 50% of recent unit timeouts occur in
the MVar DB properties:

> Broken down by tags/issues:
> 21 times (100%) #2472 Unit tests sometimes time out.
> 19 times (90%) mac
> 19 times (90%) hydra
> 10 times (48%) MVar
> 2 times (10%) buildkite

(./scripts/bors-stats.rb list --fetch-system --tag "#2472" --details true --annotate MVar)

I believe as we run the DB properties on the real Sqlite DB, and
the MVar properties in linux, we shouldn't lose much from disabling them on macOS.
@Anviking Anviking force-pushed the anviking/ADP-970/MVar-props branch from ea7d34f to 96b6cc7 Compare June 15, 2021 19:00
@Anviking Anviking self-assigned this Jun 15, 2021
@Anviking Anviking requested a review from rvl June 15, 2021 19:59
@rvl
Copy link
Contributor

rvl commented Jun 15, 2021

I see this one on Linux too.
Running those tests with profiling enabled under fluke.sh should help identify the cause.

@Anviking
Copy link
Collaborator Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 16, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 89d0a33 into master Jun 16, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-970/MVar-props branch June 16, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anviking @rvl