Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cli.md with --max_count parameter #3780

Merged
merged 1 commit into from Mar 13, 2023
Merged

update cli.md with --max_count parameter #3780

merged 1 commit into from Mar 13, 2023

Conversation

piotr-iohk
Copy link
Contributor

  • update cli.md with --max_count parameter

Comments

Issue Number

ADP-2788

@piotr-iohk piotr-iohk requested a review from paolino March 13, 2023 09:20
@piotr-iohk piotr-iohk self-assigned this Mar 13, 2023
paolino
paolino reviewed Mar 13, 2023
View reviewed changes
docs/user-guide/cli.md
```

This lists all transactions between `2018-09-25T10:15:00Z` and `2019-11-21T10:15:00Z` in `ascending` order.
This lists max 10 transactions between `2018-09-25T10:15:00Z` and `2019-11-21T10:15:00Z` in `ascending` order.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we document the fact that without max_count they will be all included? I mean it's obvious ...

paolino
paolino approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 13, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 96d626c into master Mar 13, 2023
2 checks passed
@iohk-bors iohk-bors bot deleted the piotr/update-cli-docs branch March 13, 2023 11:17
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 13, 2023
docs: Merge #3780 3780: update cli.md with --max_count parameter r=pi…
11cf4c1 
…otr-iohk a=piotr-iohk - [x] update cli.md with --max_count parameter ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-2788
 Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Source commit: 96d626c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolino paolino paolino approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piotr-iohk @paolino