[ADP-2871] use a query store for tx metas

[paolino]

• Create a QueryStore for TxMeta so that we can use an (only) on-disk store for them

ADP-2871

[HeinrichApfelmus]

Excellent, very clean, I like it! 😊 Unfortunately, there is a off-by-one error which was not caught by prop_StoreUpdates. Darn. 😳

In order to fix the off-by-one error, I think the simplest approach is to make a separate query GetAfterSlot, where the lower bound is exclusive rather than inclusive as it is for GetAll. (We could change GetAll to be exclusive on the lower bound, but this would change the semantics of listTransactions – which would be out of scope here.)

Also, I would suggest renaming GetAll to GetRange, as it's probably more appropriate.

Small request on the in-memory implementation of GetOne.

[HeinrichApfelmus]

Excellent, thank you! 😊 Would like to see remaining comments addressed before merge, though. Importantly, I would be in favor of using GetAfterSlot for both the Nothing and the Just case, as this will then ensure unit test coverage for the rollback. (One unit test checks that the queries are the same, and one unit test checks that the query is suitable for a rollback.)

[paolino]

bors r+

[iohk-bors]

Build succeeded:

• buildkite/cardano-wallet