Rename slotStartingAtOrJust{After,Before} to slot{Ceiling,Floor}.
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/slot-ceiling-floor
branch
from
da2805b
to
5f4bf50
Compare
Anviking
approved these changes
Aug 20, 2019
paweljakubas
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
None.
Overview
The functions
slotStartingAtOrJustAfterandslotStartingAtOrJustBeforeare a bit of a mouthful.The behaviour of these functions is equivalent to finding either the ceiling or the floor of a given slot.
Therefore, we rename these functions to
slotCeilingandslotFloor, respectively.Comments
A further PR will correct the behaviour (and type) of
slotFloorso that it doesn't return a slot when the specified time occurs before the start of the blockchain.