Use Set of Party to signal ReadyToCommit

Using a Set instead of a List makes it possible to expect a deterministic order in the message, whatever the commits order may be.
input-output-hk · Sep 10, 2021 · 9f3c8c1 · 9f3c8c1
1 parent ff7b2f4
commit 9f3c8c1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/hydra-node/src/Hydra/HeadLogic.hs b/hydra-node/src/Hydra/HeadLogic.hs
@@ -164,7 +164,7 @@ update Environment{party, signingKey, otherParties} ledger st ev = case (st, ev)
   (_, OnChainEvent OnInitTx{contestationPeriod, parties}) ->
     NewState
       (InitialState (HeadParameters{contestationPeriod, parties}) (Set.fromList parties) mempty)
-      [ClientEffect $ ReadyToCommit parties]
+      [ClientEffect $ ReadyToCommit $ fromList parties]
   --
   (InitialState _ remainingParties _, ClientEvent (Commit utxo))
     | canCommit -> sameState [OnChainEffect (CommitTx party utxo)]

diff --git a/hydra-node/src/Hydra/ServerOutput.hs b/hydra-node/src/Hydra/ServerOutput.hs
@@ -11,7 +11,7 @@ import Hydra.Snapshot (Snapshot)
 data ServerOutput tx
   = PeerConnected {peer :: Host}
   | PeerDisconnected {peer :: Host}
-  | ReadyToCommit {parties :: [Party]}
+  | ReadyToCommit {parties :: Set Party}
   | Committed {party :: Party, utxo :: Utxo tx}
   | HeadIsOpen {utxo :: Utxo tx}
   | HeadIsClosed {contestationDeadline :: UTCTime, latestSnapshot :: Snapshot tx}

diff --git a/local-cluster/bench/Bench/EndToEnd.hs b/local-cluster/bench/Bench/EndToEnd.hs
@@ -91,7 +91,7 @@ bench timeoutSeconds workDir dataset clusterSize =
             let contestationPeriod = 100 :: Natural
             send leader $ input "Init" ["contestationPeriod" .= contestationPeriod]
             waitFor tracer 3 nodes $
-              output "ReadyToCommit" ["parties" .= map int [1 .. fromIntegral clusterSize]]
+              output "ReadyToCommit" ["parties" .= Set.fromList (map int [1 .. fromIntegral clusterSize])]
 
             expectedUtxo <- commit nodes dataset