Propose time handling ADR #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort Transaction
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
This was referenced Aug 5, 2022
ch1bo
force-pushed
the
ch1bo/adr-20-handling-time
branch
3 times, most recently
from
f392227
to
89cfbc7
Compare
abailly-iohk
approved these changes
Aug 22, 2022
|
|
||
| * Cardano is our layer 1 and its consensus layer separates time into discrete steps, where each step is called a `Slot`. The network is expected to evolve strictly monotonically on this time scale and so slot numbers (`SlotNo`) are always increasing. | ||
|
|
||
| * The Cardano mainnet has a block scheduled every 20 seconds, although it may take longer. |
| * Cardano is our layer 1 and its consensus layer separates time into discrete steps, where each step is called a `Slot`. The network is expected to evolve strictly monotonically on this time scale and so slot numbers (`SlotNo`) are always increasing. | ||
|
|
||
| * The Cardano mainnet has a block scheduled every 20 seconds, although it may take longer. | ||
| - This is because it has `f = 0.02` and slot length is one second. |
There was a problem hiding this comment.
I see, my comment is perhaps not relevant. I would intuitively have framed things the other way round as we start introducing the concept of Slot first.
There was a problem hiding this comment.
But this is even wrong.. it should say 0.05, so thanks for pointing out 😅
| - Trying to convert wall-clock time to slots of the Head protocol deadline led to `PastHorizonException` (when using very low security parameter `k`) | ||
| - Trying to `fanout` after the deadline, but before another block has been seen by the L1 ledger led to `OutsideValidityIntervalUTxO`. | ||
|
|
||
| * The second problem scenarion and solution ideas are roughly visible on this whiteboard: |
There was a problem hiding this comment.
typo: scenarion -> scenario
| - Ensures clients only see `ReadyToFanout` when a following `Fanout` would be really possible. | ||
| - Makes the `Delay` effect redundant and we can remove it (only delay via reenqueue on the `Wait` outcome) | ||
|
|
||
| * We get a first, rough notion of time for free in our L2 and can support "timed transactions" with same resolution as the L1. |
There was a problem hiding this comment.
This would require converting back wall-clock time to slots in the L2 which is dependent on the L2 slot length.
suggestion: Add a note saying this can be made configurable by changing the config files for the L2 ledger
This is basically two decisions, but benefiting from the same context and them depending on each other made me propose a single ADR.
ch1bo
force-pushed
the
ch1bo/adr-20-handling-time
branch
from
89cfbc7
to
597fedc
Compare
ffakenz
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically two decisions, but benefiting from the same context
and them depending on each other made me propose a single ADR.