-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tui): increase feedbacks display time #506
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
8370701
to
cc77d5a
Compare
cc77d5a
to
a6dc4ac
Compare
8fe919a
to
c456477
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better (IMO), focuses more on the issue.
Tests need to adapted now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better (IMO), focuses more on the issue.
Tests need to adapted now.
70b5bac
to
0e365ca
Compare
Refactor State to have a list of feedbacks instead of a maybe value. This list will only contain `non expired` feedbacks. A feedback is expired if it is 3 seconds older than current State time. This refactor means now the widget to display is not a plain str anymore but a list str widgets. Note: No feedback will be render unless current State time is ahead of TUI application start up time. Extra: Added shouldNotRender helper to check feedbacks are getting clear.
clearing the state on every event handle.
Co-authored-by: Sebastian Nagel <ch1bo@users.noreply.github.com>
0e365ca
to
0a0a28f
Compare
… widget to work Remove unnecesary hiding imports
0a0a28f
to
ac58b23
Compare
threadDelay 1 | ||
shouldRender "Invalid command: Fanout" | ||
threadDelay 1 | ||
shouldRender "Invalid command: Fanout" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this test red on master
?
If not, there is no point in having it. I rather have a test less than one which does not check what it intends to be checking.
Fixes #484
🏓 Refactor State to have a list of feedback instead of a maybe value.
🏓 Feedback will always be visible, displaying the last error which occurs.
🏓 Extra: added
shouldNotRender
helper, as it is convenient during development.