Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract database feature from common crate #1492

Closed
5 tasks done
Alenar opened this issue Feb 8, 2024 · 0 comments · Fixed by #1494
Closed
5 tasks done

Extract database feature from common crate #1492

Alenar opened this issue Feb 8, 2024 · 0 comments · Fixed by #1494
Assignees
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@Alenar
Copy link
Collaborator

Alenar commented Feb 8, 2024

Why

We want to reduce the dependencies needed by our projects, reduce the number of features of mithril-common and make our codebase more manageable by splitting code in cohesive blocks.

What

Extract all store & database related code from mithril-common to a new local crate . This crate doesn't needs to be published to crates.io since the mithril-client doesn't use those features.

How

  • Create a new local crate (name to be defined, ie: mithril-database or mithril-store ?)
  • Add it as dependency to the nodes that needs it (should be only mithril-aggregator and mithril-signer)
  • Move the database & store related code from mithril-common to this new crate
  • Update the imports in impacted project to target the new crate
  • Remove the database feature from mithril-common
@Alenar Alenar added the refactoring 🛠️ Code refactoring and enhancements label Feb 8, 2024
@Alenar Alenar self-assigned this Feb 8, 2024
@jpraynaud jpraynaud changed the title Extract database feature from common crate? Extract database feature from common crate Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant