Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer metrics server displays confusing log message #1620

Closed
1 task done
jpraynaud opened this issue Apr 9, 2024 · 0 comments · Fixed by #1621
Closed
1 task done

Signer metrics server displays confusing log message #1620

jpraynaud opened this issue Apr 9, 2024 · 0 comments · Fixed by #1621
Assignees
@jpraynaud
Labels
devX 🌞 Developer experience

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Apr 9, 2024 •
edited

Why

Following a discussion on Discord, it appears that the metrics server displays a confusing MetricsServer: shutting down HTTP server after receiving signal signal but is still operating normally after this message is displayed.

What

Make the log message MetricsServer: shutting down HTTP server after receiving signal displayed only when a signal is caught.

How

  • Fix MetricsServer: shutting down HTTP server after receiving signal log message appearance
@jpraynaud jpraynaud self-assigned this Apr 9, 2024
@jpraynaud jpraynaud added the devX 🌞 Developer experience label Apr 9, 2024
@jpraynaud jpraynaud mentioned this issue Apr 9, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpraynaud jpraynaud

Labels
devX 🌞 Developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix signer metrics server caught signal log input-output-hk/mithril
1 participant
@jpraynaud