Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Ord on SignedEntityTypeDiscriminants #1648

Closed
1 of 2 tasks
jpraynaud opened this issue Apr 22, 2024 · 0 comments · Fixed by #1669
Closed
1 of 2 tasks

Implement Ord on SignedEntityTypeDiscriminants #1648

jpraynaud opened this issue Apr 22, 2024 · 0 comments · Fixed by #1669
Assignees
@Alenar
Labels
optimization 🛠️ Optimization and/or small enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Apr 22, 2024 •
edited by Alenar

Why

We want to have all the aggregators compute the order of signed entity types used to create open messages in a consistent way.

What

Implement Ord trait on the SignedEntityTypeDiscriminants type and use this order in the aggregator state machine during the computation of the next open message

How

  • Implement Ord trait on the SignedEntityTypeDiscriminants type
  • Use the ordering in the computation of the next open message in the aggregator
@jpraynaud jpraynaud added the optimization 🛠️ Optimization and/or small enhancements label Apr 22, 2024
@Alenar Alenar mentioned this issue May 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alenar Alenar

Labels
optimization 🛠️ Optimization and/or small enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ord on signed entity type discriminants input-output-hk/mithril
2 participants
@Alenar @jpraynaud