Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cardano node version part of the Mithril network configuration #947

Closed
3 tasks done
jpraynaud opened this issue May 26, 2023 · 2 comments
Closed
3 tasks done
Assignees
Labels
D-medium Difficulty: medium devX 🌞 Developer experience documentation 📖 Documentation to add/update optimization 🛠️ Optimization and/or small enhancements task

Comments

@jpraynaud
Copy link
Member

jpraynaud commented May 26, 2023

Issue

The ledger state used to fast bootstrap the Cradano nodes may change from one release of the node to another.
For example, a breaking change was introduced between 1.35.7 and 8.0.0: this means that a ledger state created with 1.35.7 would need to be recomputed (i.e. replay all blocks) when restored on a node running 8.0.0 (and reciprocally). This does not prevent Cardano nodes to be restored, but it introduces a delay that will limit the speed of restoration.

We want to provide a clear information about which versions of Cardano node are optimum for restoration for each Mithril network.

To do

  • Add a Cardano node version range field in the configuration matrix for each network of the documentation
  • Add a note/warning in the documentation to explain what happens if the Cardano node version used to restore is not in the range of the Mithril network
  • Add the Cardano node version in the command displayed by the Mithril client download command (at least in the documentation)
@jpraynaud jpraynaud added D-medium Difficulty: medium task dev 💪 optimization 🛠️ Optimization and/or small enhancements documentation 📖 Documentation to add/update labels May 26, 2023
@jpraynaud jpraynaud added the devX 🌞 Developer experience label Jul 27, 2023
@jpraynaud jpraynaud added the to-plan 📆 To plan in a sprint label Aug 10, 2023
@ghubertpalo ghubertpalo self-assigned this Aug 29, 2023
@ghubertpalo
Copy link
Collaborator

It seems not possible to get the Cardano node version using the Cardano CLI tool (which can just pop out its own version). See this Stack-Overflow post.
I will make the assumption the Cardano CLI is the same version as the node.

@jpraynaud
Copy link
Member Author

jpraynaud commented Aug 29, 2023

In the documentation the versions are declarative and will be updated manually.

In issue #948, you can assume that the version of the Cardano node is the version given by the Cardano cli with cardano-cli --version as they are deployed together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-medium Difficulty: medium devX 🌞 Developer experience documentation 📖 Documentation to add/update optimization 🛠️ Optimization and/or small enhancements task
Projects
None yet
Development

No branches or pull requests

2 participants