Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean pending_snapshot directory of aggregator #983

Closed
2 tasks done
jpraynaud opened this issue Jun 15, 2023 · 1 comment · Fixed by #1011
Closed
2 tasks done

Clean pending_snapshot directory of aggregator #983

jpraynaud opened this issue Jun 15, 2023 · 1 comment · Fixed by #1011
Labels
D-easy Difficulty: easy good first issue 👋 Good for newcomers optimization 🛠️ Optimization and/or small enhancements task

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jun 15, 2023

Issue

The pending_snapshot directory is never cleaned and some uncompleted snapshots stay forever.
This can create a storage issue (particularly with the mainnet archives).

To do

  • Clear pending_snapshot before or after snapshot archive is created
  • Clear pending_snapshot at aggregator startup
@jpraynaud jpraynaud added D-easy Difficulty: easy task dev 💪 optimization 🛠️ Optimization and/or small enhancements good first issue 👋 Good for newcomers labels Jun 15, 2023
@dlachaume
Copy link
Collaborator

The temp files in the pending_snapshot directory were only removed after a successful upload.

Now, pending_snapshot directory is cleaned at aggregator startup and uncompleted snapshots archives are removed at every step :

  • if an error occurs during the creation of the archive
  • if an error occurs during the upload

More details in the PR #1011 description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-easy Difficulty: easy good first issue 👋 Good for newcomers optimization 🛠️ Optimization and/or small enhancements task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants