-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an MVP of a benchmarks comparison tool #161
Conversation
For the time being this tool simply outputs the top 10 improvements and degradation wrt the baseline version. Sample output comparing
This tool also plots the outliers, eg: |
hs-source-dirs: app | ||
main-is: beacon.hs | ||
build-depends: | ||
, ansi-terminal | ||
, base | ||
, bytestring | ||
, cassava | ||
, Chart | ||
, Chart-cairo | ||
, containers | ||
, directory | ||
, extra | ||
, process | ||
, statistics | ||
, text | ||
, vector | ||
, vector-algorithms | ||
|
||
ghc-options: | ||
-Wall -Wcompat -Wincomplete-uni-patterns | ||
-Wincomplete-record-updates -Wpartial-fields -Widentities | ||
-Wredundant-constraints -Wmissing-export-lists -Wunused-packages | ||
-Wno-unticked-promoted-constructors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hs-source-dirs: app | |
main-is: beacon.hs | |
build-depends: | |
, ansi-terminal | |
, base | |
, bytestring | |
, cassava | |
, Chart | |
, Chart-cairo | |
, containers | |
, directory | |
, extra | |
, process | |
, statistics | |
, text | |
, vector | |
, vector-algorithms | |
ghc-options: | |
-Wall -Wcompat -Wincomplete-uni-patterns | |
-Wincomplete-record-updates -Wpartial-fields -Widentities | |
-Wredundant-constraints -Wmissing-export-lists -Wunused-packages | |
-Wno-unticked-promoted-constructors | |
import: common-exe | |
hs-source-dirs: app | |
main-is: beacon.hs | |
build-depends: | |
, ansi-terminal | |
, base | |
, bytestring | |
, cassava | |
, Chart | |
, Chart-cairo | |
, containers | |
, directory | |
, extra | |
, process | |
, statistics | |
, text | |
, vector | |
, vector-algorithms |
ee01711
to
68fb65a
Compare
I ran the bench comparison tool through the chain I have locally and got some interesting results. Even though I did not perform statistical analysis, we can already see that the latest version of Consensus + Ledger got considerably faster (which I think we expected given the work Ledger did in the incremental rewards calculations ). I would guess that we can also detect serious regressions in this way. Version |
4dd8692
to
3e132e7
Compare
3e132e7
to
4c51b9e
Compare
556a93d
to
4c2e65c
Compare
The tool does not build with
So the only option I see is to upstream a PR to |
Based on the requirements gathered in #142, Closes #153
See the documentation in the
Main
module for more details.