Chain switch trace events: record old and new SelectView
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
force-pushed
the
amesgen/chain-switch-trace-SelectView
branch
from
7361fd8
to
cd46472
Compare
nfrisby
reviewed
Oct 2, 2023
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/Types.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/Types.hs
Show resolved
Hide resolved
amesgen
force-pushed
the
amesgen/chain-switch-trace-SelectView
branch
from
cd46472
to
44c503b
Compare
amesgen
force-pushed
the
amesgen/chain-switch-trace-SelectView
branch
from
44c503b
to
7458090
Compare
nfrisby
approved these changes
Oct 2, 2023
| @@ -636,7 +649,7 @@ data TraceAddBlockEvent blk = | |||
| -- chain (second fragment). | |||
| | AddedToCurrentChain | |||
| [LedgerEvent blk] | |||
| (NewTipInfo blk) | |||
| (SelectionChangedInfo blk) | |||
There was a problem hiding this comment.
Once this diff context appear it occurred to me that perhaps the dowstream use cases of NewTipInfo/SelectionChangedInfo could just get the SelectView from the two header chain arguments.
However, Esgen pointed out the call site would then need to also have the BlockConfig in scope. (That's certainly always possible, but likely often onerous).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.