Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurify documentation #6

Merged
merged 6 commits into from Feb 9, 2023
Merged

Conversation

abailly-iohk
Copy link
Contributor

@abailly-iohk abailly-iohk commented Feb 7, 2023

This PR uses docusaurus to structure the documentation site. This PR is still in draft because I need to add github actions to publish it with the new style.

Screenshot 2023-02-07 at 13 19 30
Screenshot 2023-02-07 at 13 19 43

@abailly-iohk abailly-iohk marked this pull request as draft February 7, 2023 12:21
@dnadales dnadales marked this pull request as ready for review February 8, 2023 09:11
Copy link
Member

@dnadales dnadales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -22,4 +22,39 @@ document](CONTRIBUTING.md).
Issues can be filled in our [GitHub issue
tracker](https://github.com/input-output-hk/ouroboros-consensus/issues).

## Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be a sub-section of Documentation: once we add the Consensus code this could lead to confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall rewrite the README when we merge consensus code in this repo, I guess/

### Local Development

```
$ yarn start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add a .nix file that provides a yarn installation (I could do it in a separate PR). I found it quite handy!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good idea, and something easy to do (even I could do it :) )!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants