Skip to content

Commit

Permalink
p2p-governor: Add review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
dcoutts authored and coot committed Sep 28, 2021
1 parent fb81a89 commit f03fd47
Showing 1 changed file with 4 additions and 2 deletions.
Expand Up @@ -152,10 +152,10 @@ tests =
--
-- * A public root peers target property: that the governor hits its target for
-- for the number of public root peers (or as near as possible), and does
-- note "grossly" overshoot. Since the public roots is a one sided target, but
-- not "grossly" overshoot. Since the public roots is a one sided target, but
-- we don't want to overshoot excessively.
--
-- * A local root peers target property: that the governor hits it target for
-- * A local root peers target property: that the governor hits its target for
-- getting all its local root peers into the established state, and a target
-- number of them into the active state (or as near as possible).
--
Expand Down Expand Up @@ -445,6 +445,8 @@ prop_governor_trace_coverage env =
in coverTable "trace events" [ (n, 1) | n <- Map.elems allTraceNames ] $
tabulate "trace events" (Map.elems traceNamesSeen)
True
--TODO: use cover to check we do indeed get them all. There are a few
-- cases we do not cover yet. These should be fixed first.

collectTraces :: [(Time, TestTraceEvent)] -> Set Int
collectTraces trace =
Expand Down

0 comments on commit f03fd47

Please sign in to comment.