Win32 API misuse: ReadFile

[dcoutts]

ouroboros-network/Win32-network/cbits/Win32Async.c in HsAsyncRead calls ReadFile specifying both an lpNumberOfBytesRead parameter and an lpOverlapped parameter. Per documentation at https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-readfile “Use NULL for this parameter [lpNumberOfBytesRead] if this is an asynchronous operation to avoid potentially erroneous results.” If synchronous operation is desired instead, the value assigned to that parameter (numBytesRead) should be returned to the caller instead of discarded and lpOverlapped should not be specified. If asynchronous operation is desired, only the lpOverlapped parameter should be set.

As reported by Root9B.