Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one in mkPipeliningDecision #1595

Closed
edsko opened this issue Feb 6, 2020 · 0 comments
Closed

Fix off-by-one in mkPipeliningDecision #1595

edsko opened this issue Feb 6, 2020 · 0 comments
Assignees
@mrBliss
Labels
bug Something isn't working consensus issues related to ouroboros-consensus technical debt
Milestone
S6 2020-02-13

Comments

@edsko
Copy link
Contributor

edsko commented Feb 6, 2020

Currently mkPipelineDecision takes a BlockNo, but we might not have one (we might be at genesis). We should fix that, and then use that in consensus #1589 (comment) . This probably also will remove one use of the legacy tip API (#1587).
@edsko edsko added bug Something isn't working consensus issues related to ouroboros-consensus networking technical debt labels Feb 6, 2020
@edsko edsko mentioned this issue Feb 6, 2020
Merged
@mrBliss mrBliss added this to the S6 2020-02-13 milestone Feb 6, 2020
mrBliss added a commit that referenced this issue Feb 6, 2020
@mrBliss
ChainSyncClient: use WithOrigin BlockNo for MkPipelineDecision
ee074fc 
Fixes #1595.
@mrBliss mrBliss mentioned this issue Feb 6, 2020
Merged
@mrBliss mrBliss self-assigned this Feb 6, 2020
iohk-bors bot added a commit that referenced this issue Feb 7, 2020
@iohk-bors @mrBliss
Merge #1597
9139f1f 
1597: Follow-up on #1589 r=mrBliss a=mrBliss

Fixes #1594 and #1595.

* ChainSyncClient: use WithOrigin BlockNo for MkPipelineDecision

* ChainDB: don't read the header at the ImmutableDB's tip on startup


Co-authored-by: Thomas Winant <thomas@well-typed.com>
@iohk-bors iohk-bors bot closed this as completed in 2ff3a38 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrBliss mrBliss

Labels
bug Something isn't working consensus issues related to ouroboros-consensus technical debt
Projects
None yet
Milestone
S6 2020-02-13
Development

No branches or pull requests
2 participants
@mrBliss @edsko