Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize ChainSelection for HardForkProtocol #2118

Closed
edsko opened this issue May 19, 2020 · 1 comment · Fixed by #2416
Closed

Generalize ChainSelection for HardForkProtocol #2118

edsko opened this issue May 19, 2020 · 1 comment · Fixed by #2416
Assignees
@edsko
Labels
consensus issues related to ouroboros-consensus transition
Milestone
S17 2020-07-16

Comments

@edsko
Copy link
Contributor

edsko commented May 19, 2020 •
edited

The definition as it stands uses BlockNo when the two tips are from different eras. This would mean that we cannot compare certificate numbers when transitioning from Shelley to Shelley-MC or Goguen.

This is not necessary until after Shelley, so marking this as enhancement.
@edsko edsko added consensus issues related to ouroboros-consensus transition priority high labels May 19, 2020
@edsko edsko self-assigned this May 19, 2020
@edsko
Copy link
Contributor Author

edsko commented May 19, 2020

Can define a trivial translation where if the SelectViews happen to match, we just compare across the transition.

@edsko edsko removed their assignment May 21, 2020
@edsko edsko added the enhancement New feature or request label May 21, 2020
@kevinhammond kevinhammond added this to To do in Hard Fork Combinator via automation May 29, 2020
@edsko edsko added goguen and removed enhancement New feature or request labels Jun 30, 2020
@mrBliss mrBliss removed this from To do in Hard Fork Combinator Jun 30, 2020
@mrBliss mrBliss added vit and removed goguen labels Jun 30, 2020
@mrBliss mrBliss added this to the S17 2020-07-16 milestone Jun 30, 2020
edsko added a commit that referenced this issue Jul 16, 2020
@edsko
Generalize chain selection
be75881 
Closes #2118.
@edsko edsko mentioned this issue Jul 16, 2020
Merged
iohk-bors bot added a commit that referenced this issue Jul 16, 2020
@iohk-bors @edsko
Merge #2416
c626335 
2416: Generalize chain selection r=edsko a=edsko

Closes #2118.

Co-authored-by: Edsko de Vries <edsko@well-typed.com>
@iohk-bors iohk-bors bot closed this as completed in 3195f35 Jul 16, 2020
@iohk-bors iohk-bors bot closed this as completed in #2416 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsko edsko

Labels
consensus issues related to ouroboros-consensus transition
Projects
None yet
Milestone
S17 2020-07-16
Development

Successfully merging a pull request may close this issue.

Generalize chain selection IntersectMBO/ouroboros-network
2 participants
@mrBliss @edsko