Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shelley: check if key is okay in checkIsLeader #2171

Closed
edsko opened this issue May 29, 2020 · 1 comment
Closed

Shelley: check if key is okay in checkIsLeader #2171

edsko opened this issue May 29, 2020 · 1 comment
Assignees
@nc6
Labels
consensus issues related to ouroboros-consensus
Milestone
S14 2020-06-04

Comments

@edsko
Copy link
Contributor

edsko commented May 29, 2020

See #2169.

Marking this as high priority because logging information about invalid blocks being produced is terrifying, whereas messages about keys being out of date just means PEBKAC.
@edsko edsko added consensus issues related to ouroboros-consensus shelley mainnet labels May 29, 2020
@edsko edsko added this to the S15 2020-06-18 milestone May 29, 2020
@edsko edsko mentioned this issue Jun 1, 2020
Closed
@nc6 nc6 mentioned this issue Jun 2, 2020
Merged
iohk-bors bot added a commit that referenced this issue Jun 4, 2020
@iohk-bors @nc6
Merge #2193
f4b23d7 
2193: Implement `CannotLead` for Shelley r=edsko a=nc6

Addresses #2171 

Co-authored-by: Nicholas Clarke <nick@topos.org.uk>
@mrBliss mrBliss modified the milestones: S15 2020-06-18, S14 2020-06-04 Jun 5, 2020
@mrBliss
Copy link
Contributor

mrBliss commented Jun 5, 2020

Closed by #2193

@mrBliss mrBliss closed this as completed Jun 5, 2020
coot pushed a commit that referenced this issue May 16, 2022
@iohk-bors @nc6
Merge #2193
ff91aac 
2193: Implement `CannotLead` for Shelley r=edsko a=nc6

Addresses #2171 

Co-authored-by: Nicholas Clarke <nick@topos.org.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nc6 nc6

Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
S14 2020-06-04
Development

No branches or pull requests
3 participants
@mrBliss @edsko @nc6