Upper bound for CBOR-in-CBOR tag is 7 instead of 5 bytes #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently we sometimes generate blocks that are 65536 bytes large or more, requiring a 7 byte CBOR-in-CBOR tag (65535 would only require 5 bytes), failing the test added in #2481, as our upper bound assumed 5 bytes.
mrBliss
force-pushed
the
mrBliss/fix-cbor-in-cbor-estimate
branch
from
07db1b1
to
c4b76e7
Compare
edsko
approved these changes
Jul 31, 2020
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we sometimes generate blocks that are 65536 bytes large or more,
requiring a 7 byte CBOR-in-CBOR tag (65535 would only require 5 bytes), failing
the test added in #2481, as our upper bound assumed 5 bytes.