-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some micro- benchmarks for PeerMetrics #4663
Add some micro- benchmarks for PeerMetrics #4663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
17cbc34
to
c9979ee
Compare
There's a build failure: https://github.com/input-output-hk/ouroboros-network/actions/runs/6212332000/job/17104416622; It seems wrong version of |
Head branch was pushed to by a user without write access
c9979ee
to
1b3420c
Compare
1b3420c
to
f1cc348
Compare
- new bench/Main.hs - new cabal target - extending ouroboros-network/sim-tests/**/PeerMetric.hs
- separate library and executable stanzas
* also exposes project at top-level for debugging
* `sim-tests-lib` in `sim-test-lib` subdirectory * `sim-test` in `sim-test` subdirectory
8469818
to
693d2b3
Compare
@mtullsen I rebased the PR, and added a few benign commits on top. |
693d2b3
to
864f085
Compare
* Added standard GHC flags, including `-Wunused-packages`. I only omitted `-Wredundant-constraints` which requires a lot of code changes. * Removed `sim-test-common` stantza as it was pulling a lot of dependencies where they are not needed.
864f085
to
7d0ccbe
Compare
Description
This resolves #3832.
The goals of this PR are to
One can run the benchmark thus
Checklist