Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepAlive client #4689

Closed
coot opened this issue Oct 9, 2023 · 1 comment · Fixed by #4693
Closed

KeepAlive client #4689

coot opened this issue Oct 9, 2023 · 1 comment · Fixed by #4693
Labels
keep-alive Issues / PRs related to keep-alive protocol

Comments

@coot
Copy link
Contributor

coot commented Oct 9, 2023

The keep alive client has two small issues:

  1. it should record time when it sends the initial MsgKeepAlive, and compute the rtt when we receive the reply.
  2. currently after first round trip with MsgKeepAlive -> MsgKeepAliveResponse, we immediately send the next MsgKeepAlive message without doing the delay. If we refactor the code to fix the first issue we will actually fix this one as well, if we eliminate ref.
@coot coot added the keep-alive Issues / PRs related to keep-alive protocol label Oct 9, 2023
@karknu
Copy link
Contributor

karknu commented Oct 10, 2023

Will look into this.

@karknu karknu mentioned this issue Oct 17, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep-alive Issues / PRs related to keep-alive protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

KeepAlive Client collect samples on first packet karknu/ouroboros-network
2 participants
@coot @karknu