Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim typed-transitions dependencies, use QuickCheck 2.12 even on older GHCs, allow STM prior to 2.5 #134

Merged
merged 8 commits into from Dec 18, 2018

Conversation

avieth
Copy link
Contributor

@avieth avieth commented Dec 14, 2018

typed-transitions.cabal still had dependencies for packages that it no longer uses. I also got rid of the async dependency by abstracting over a concurrently :: IO a -> IO b -> IO (a,b) for the ping pong example demo.

Besides that, I've been preparing to use the iohk-monitoring package as a dependency, and noticed that a ghc844 build would fail because it chooses by default a more well-supported and accepted QuickCheck < 2.12. We use 2.12 so I added that to the overrides for all GHCs in nix/nixpkgs.nix as well as the required hspec versions to use it.

Also used CPP to allow for stm prior to 2.5. This makes it easier to build on older GHCs and package sets.

@avieth avieth changed the title trim typed-transitions dependencies, use QuickCheck 2.12 even on older GHCs trim typed-transitions dependencies, use QuickCheck 2.12 even on older GHCs, allow STM prior to 2.5 Dec 14, 2018
@avieth avieth requested review from coot and edsko December 14, 2018 18:56
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot added the nix This includes CI, nix changes or cabal dependencies label Dec 17, 2018
@avieth
Copy link
Contributor Author

avieth commented Dec 17, 2018

Builds are now failing because the final cachix invocations apparently take more than 10 minutes and don't produce any output. What to do about this?

@coot
Copy link
Contributor

coot commented Dec 18, 2018

It seems it was stale on pushing /nix/store/wc4chfs9wgi67g1r7im93358h1j6cdkz-ghc-8.4.4. I am actually surprised that this one did not come from nix cache. We could try to update the revision in nix/nixpkgs.nix.

@avieth avieth merged commit 0800a81 into master Dec 18, 2018
@avieth avieth deleted the avieth/nix_dependencies branch December 18, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nix This includes CI, nix changes or cabal dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants