Fix #1573: ReadFile: pass NULL pointer to lpNumberOfBytesRead #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only use 'ReadFile' in asynchronous way, and thus we should pass a null pointer: https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-readfile
|
I had a todo for that, but somehow I lost it ... it's good that the reviewer brought this back. bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 4, 2020
1576: Fix #1573: ReadFile: pass NULL pointer to lpNumberOfBytesRead r=coot a=coot We only use 'ReadFile' in asynchronous way, and thus we should pass a null pointer: https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-readfile Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use 'ReadFile' in asynchronous way, and thus we should pass
a null pointer:
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-readfile