Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up on #1589 #1597

Merged
merged 3 commits into from Feb 7, 2020
Merged

Follow-up on #1589 #1597

merged 3 commits into from Feb 7, 2020

Conversation

mrBliss
Copy link
Contributor

@mrBliss mrBliss commented Feb 6, 2020

Fixes #1594 and #1595.

  • ChainSyncClient: use WithOrigin BlockNo for MkPipelineDecision

  • ChainDB: don't read the header at the ImmutableDB's tip on startup

@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Feb 6, 2020
@mrBliss mrBliss requested review from coot and edsko February 6, 2020 13:04
edsko
edsko approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@edsko edsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good to see it working out. Just one use of legacyTip left in the ChainSyncClient, would be nice to delete it.

ouroboros-consensus/src/Ouroboros/Consensus/ChainSyncClient.hs Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Storage/ChainDB/Impl/ImmDB.hs Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Storage/ChainDB/Impl/Reopen.hs Show resolved Hide resolved
ouroboros-network/protocol-tests/Ouroboros/Network/Protocol/ChainSync/ExamplesPipelined.hs Outdated Show resolved Hide resolved
@edsko edsko mentioned this pull request Feb 7, 2020
Open
@mrBliss
Copy link
Contributor Author

mrBliss commented Feb 7, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 7, 2020
@iohk-bors @mrBliss
Merge #1597
9139f1f 
1597: Follow-up on #1589 r=mrBliss a=mrBliss

Fixes #1594 and #1595.

* ChainSyncClient: use WithOrigin BlockNo for MkPipelineDecision

* ChainDB: don't read the header at the ImmutableDB's tip on startup


Co-authored-by: Thomas Winant <thomas@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 7, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 9b0a67d into master Feb 7, 2020
@iohk-bors iohk-bors bot deleted the mrBliss/follow-up-1589 branch February 7, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsko edsko edsko approved these changes

@nfrisby nfrisby nfrisby left review comments

@coot coot Awaiting requested review from coot

Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid reading the header in ChainDB
3 participants
@mrBliss @edsko @nfrisby