Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thunks in RealPBFT #1602

Merged
merged 2 commits into from Feb 7, 2020
Merged

Fix thunks in RealPBFT #1602

merged 2 commits into from Feb 7, 2020
+21 −18

Conversation

mrBliss
Copy link
Contributor

@mrBliss mrBliss commented Feb 7, 2020

This fixes the thunks found by running the RealPBFT consensus tests with the checktvarinvariant flag enabled for the io-sim-classes package.

@mrBliss
Make PBftValidationErr strict
02df922 
This type is being stored in the state of the ChainDB, so to pass the
NoUnexpectedThunks checks, it has to be strict in its arguments.
@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Feb 7, 2020
@mrBliss mrBliss requested a review from edsko February 7, 2020 12:23
@mrBliss
Copy link
Contributor Author

mrBliss commented Feb 7, 2020

If we had IntersectMBO/ouroboros-consensus#756, we would have discovered this much sooner.

edsko
edsko approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@edsko edsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure though

@mrBliss
Copy link
Contributor Author

mrBliss commented Feb 7, 2020

CI failure (dependency not in master) is because bors still hasn't merged IntersectMBO/cardano-ledger#717 😩

@edsko
Copy link
Contributor

edsko commented Feb 7, 2020

Oh, right. Come back in a week.

@mrBliss
Copy link
Contributor Author

mrBliss commented Feb 7, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 7, 2020
@iohk-bors @mrBliss
Merge #1602
ea8a0c3 
1602: Fix thunks in RealPBFT r=mrBliss a=mrBliss

This fixes the thunks found by running the RealPBFT consensus tests with the `checktvarinvariant` flag enabled for the `io-sim-classes` package.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 7, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 0cc6a1d into master Feb 7, 2020
@iohk-bors iohk-bors bot deleted the mrBliss/fix-thunks branch February 7, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsko edsko edsko approved these changes

@intricate intricate intricate approved these changes

Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrBliss @edsko @intricate