Shelley: update query type of LocalStateQuery protocol #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
approved these changes
Mar 25, 2020
| @@ -239,20 +248,81 @@ instance LedgerDerivedInfo (ShelleyBlock c) where | |||
| QueryLedger | |||
| -------------------------------------------------------------------------------} | |||
|
|
|||
| newtype NonMyopicMemberRewards c = NonMyopicMemberRewards { | |||
There was a problem hiding this comment.
Do we want to move this over to cardano-ledger-specs at some point?
ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Ledger/Ledger.hs
Outdated
Show resolved
Hide resolved
| @@ -261,6 +331,9 @@ instance Crypto c => ShowQuery (Query (ShelleyBlock c)) where | |||
| getPParams :: SL.ShelleyState c -> SL.PParams | |||
| getPParams = SL.esPp . SL.nesEs | |||
|
|
|||
| getProposedPPUpdates :: SL.ShelleyState c -> SL.ProposedPPUpdates c | |||
There was a problem hiding this comment.
What's the proposed use of this? I'm tempted to say that in its current form it isn't terribly useful, since this gives no indication of when the proposal will come in or whether it's likely to do so...
Is IntersectMBO/cardano-ledger#1337 likely to be useful here?
There was a problem hiding this comment.
I must admit that I'm not familiar with all these types. I wouldn't be surprised that we'll need to extend the Query type in the future. But that shouldn't be too difficult. This PR adds the necessary infrastructure (+ test infrastructure) so that future updates should be straightforward.
It will be needed for Shelley.
mrBliss
force-pushed
the
mrBliss/update-shelley-query
branch
from
0ff6990
to
2b3be37
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442.