Send timeout #1953
Send timeout #1953
Conversation
karknu
force-pushed
the
karknu/send_timeout
branch
from
9987cdd
to
ebe5200
Compare
|
Implements #1949 |
| traceWith muxTracer $ Mx.MuxTraceHandshakeClientError err (diffTime ts_end ts_start) | ||
| throwIO err | ||
| Right (Right app) -> do | ||
| Just (Right (Right app)) -> do |
There was a problem hiding this comment.
Can we simplify the Maybe (Either _ (Either _ r)) type?
There was a problem hiding this comment.
what about this idea:
data HandshakeException a =
HandshakeProtocolLimit ProtocolLimitfailure
| HandshakeProtocolError a
| HanshakeTimeout
tryHandshake :: m (Either a r) -> m (Either (HanshakeException a) r)
tryHandshaket = ... withTimeoutSerial ... try ...
The a in tryHandshake would be different for client and server.
There was a problem hiding this comment.
A great idea!
The type signature for a tryHanshake usable by both initiator and responder will look far worse than the Maybe (Either _ (Either _ r)) it is replacing.
There was a problem hiding this comment.
Really? Even though HandshakeException a is polymorphic?
There was a problem hiding this comment.
I tried and failed to get around the need for a Maybe (Either _ (Either _ r)) case statement in tryHandshake which made things far worse.
The updated code works and is more like your initial suggestion.
karknu
force-pushed
the
karknu/send_timeout
branch
from
061fc90
to
2e311bf
Compare
Simplify mux timeout code by taking advantage of that negative timeouts means no timeout.
Use an overall timeout of 10s which covers both send and recv time.
karknu
force-pushed
the
karknu/send_timeout
branch
from
2e311bf
to
785c6c9
Compare
|
bors r+ |
No description provided.